feat: add tests for binary search trees#1769
Merged
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom Jan 15, 2025
Merged
feat: add tests for binary search trees#1769raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
raklaptudirm merged 1 commit intoTheAlgorithms:masterfrom
Conversation
ridge-kimani
force-pushed
the
feat/binary-search-tree-specs
branch
from
2877788 to
eb71e2e
Compare
raklaptudirm
approved these changes
Jan 10, 2025
anandfresh
reviewed
Jan 15, 2025
| return found.value | ||
| if (this.root) { | ||
| const found = this.root.search(val) | ||
| if (found !== null) { |
There was a problem hiding this comment.
Just a shorthand recommendation.
Checking for if(found) { will check for not null and not undefined .
So no need to explicitly use if (found !== null) {
Contributor
Author
There was a problem hiding this comment.
The search return value can only be null or a Node, hence the implicit check.
search(val) {
if (this.value === val) {
return this
} else if (val < this.value && this.left !== null) {
return this.left.search(val)
} else if (val > this.value && this.right !== null) {
return this.right.search(val)
}
return null
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.